Fix breaking changes from updating Strum dependency

tjtelan / git-url-parse-rs

Parser of git repo urls for Rust

MIT License

15 stars 6 forks source link

Fix breaking changes from updating Strum dependency #14

Closed tjtelan closed 3 years ago

tjtelan commented 3 years ago

PR #13 revealed that there's a breaking change when updating the version specifier on the strum dependency.

[x] Update Cargo.toml : strum + strum_macros to ^0.20
[ ] Fix code break from Cargo.toml changes
[x] Bump crate version to 0.3.1 (minor version change)

tjtelan commented 3 years ago

I didn't experience any build failures when updating the strum versions to ^0.20, and the Github Actions CI run seems to have passed. I don't see any obvious reasons to consider not call this fixed. I'll add some notes to the changelog and publish this crate.

EverlastingBugstopper commented 3 years ago

I didn't experience any build failures when updating the strum versions to ^0.20

ah! i think i was attempting to do too much by removing strum_macros and importing them via strum = { features = ["derive"] } - makes sense that just updating the versions by themselves works fine 😄 thanks for cutting this release!

tjtelan commented 3 years ago

Coincidentally I also had a local build failure with strum imports initially when I wrote up this issue. But it seemed to be cache related, because I couldn't reproduce the failure after a cargo clean.