search

tjvantoll / nativescript-IQKeyboardManager

NativeScript wrapper for the popular IQKeyboardManager iOS framework
MIT License
100 stars 20 forks source link

Update Pod to newer version 6.5.3 #66

Closed hazzo closed 4 years ago

hazzo commented 4 years ago

Update to last version of the IQKeyboardManager Pod (6.5.3), and change the version number to automatically update the dependency up to MINOR changes and not MAJOR.

If update only to PATCH version is intended, justy modify podfile to new version: pod 'IQKeyboardManager', '~> 6.5.3'

hazzo commented 4 years ago

Thanks!👍

EddyVerbruggen commented 4 years ago

Thank you! I'm testing this and will release a new npm version soon.

hazzo commented 4 years ago

Cool, yeah It might break something but if the pod respects de sem versioning it really shouldn’t.

EddyVerbruggen commented 4 years ago

Well, it turned out it actually broke something; currently, with any version beyond 6.2.0 you can no longer use the <PreviousNextView> tag to skip to the next input field (moving back works). So I can't release this, sorry. Reverted in #67.

Was there any specific issue that 6.5.x fixed for you?

hazzo commented 4 years ago

Oh what a shame. No there was no specific issue, but since 6.3 (as I can see in their change log) there are plenty of fixes and improvements (Support for iOS13 dark theme, support Xcode 11, fixes regarding text view -this might fix a bug that I sorted out with a hack- and fix with special hierarchy UIScrollView -> UIStackView -> UITextField).

There is a new way to skipping to next input? Can I give you a hand looking into it?

Thanks again!

EddyVerbruggen commented 4 years ago

Well, the plugin uses the method the library recommends (which always worked), but beyond 6.2.0 it will only navigate to previous fields, not to next fields.

I tried TextView instead of TextField and that actually works (see the demo in this repo), so there could be something in NativeScript we can change to support TextFields as well.. but I can imagine it will require some trial & error. My hunch is we need to add a little timeout somewhere. Perhaps override a method in this class and add the timeout there(?)..

hazzo commented 4 years ago

Hmmmm it could be.

If I manage to get some time one of this days I’ll download the plugin and debug it with the demo and see what I can get of it. I’ve done no plugin for NativeScript yet but I’m interested in, so it will help me too diving into this issue.

Thanks again for answering and the efforts you put in your plugins!