search

tjvr / kurt

Python library for reading/writing MIT's Scratch file format.
https://kurt.tjvr.org
GNU General Public License v3.0
86 stars 24 forks source link

Add default colormap support and correct alignment in 8-bit images. #4

Closed bboe closed 12 years ago

bboe commented 12 years ago

Also cleaned up some trailing whitespace and some 80-column width issues.

tjvr commented 12 years ago

I am very confused, and I feel like a moron. I've implemented default colormap support and fixed the alignment with images already, but I think I just haven't merged it to master yet. (It might be on the "decompiler" branch?)

Massive apologies; and thanks so much for doing this. I'll have a look through both of our versions — I have a feeling your implementation might be better... :)

bboe commented 12 years ago

Doh! No worries though, I should have checked the branch for other updates first. I'll update my pull requests with any refactoring (if needed) on that branch.

tjvr commented 12 years ago

I'm so sorry! D: Sounds great — there are some new changes from today, too, that I haven't synced just yet. I'll do that now...

On Friday, 25 May 2012 at 22:59, Bryce Boe wrote:

Doh! I think I should look at that branch for the changes then. I'll update my pull requests with any refactoring (if needed) on that branch.

bboe commented 12 years ago

So I just confirmed that the other branch does fix the 8-bit alignment issue, however, the colormap isn't complete as I am getting list index out of range errors. It turns out that my map may be slightly off as some of my colors appear inverted. I'm looking into that, and I'll integrate my changes into the other branch once I have it worked out.

bboe commented 12 years ago

Added pull request #5 for your development branch. Closing this.