search

tjvr / tosh2

text-based Scratch project editor, Take Two.
73 stars 15 forks source link

/app/JSZip.js does not exist #7

Closed bates64 closed 7 years ago

bates64 commented 7 years ago

ReferenceError: JSZip is not defined

Thrown from tosh.bundle.js after a Webpack build. This is just a case of OS differences, I believe. I'm assuming that, @tjvr, you're on a Mac here: on Linux/Windows filenames are case sensitive, unlike on Macs!

The problem here is that /build/index.html has this line:

<script src=/app/JSZip.js></script>

Whereas the actual filename is jszip.js.

tjvr commented 7 years ago

Ah, exciting. I hadn't noticed the difference in case, since I am indeed on a Mac :-)

Would you mind putting in a PR to fix this, and fix app/index.html as well if needed? Thanks!

tjvr commented 7 years ago

FWIW, I'm not particularly convinced Webpack is the best thing; but that's not really relevant here...

TheInitializer commented 7 years ago

Correction: On Windows filenames (and pretty much everything) are case-insensitive. I thought Mac filenames were case-sensitive, but I guess I'm wrong 📦

edit: confirmed, both Windows and Mac filenames are case-insensitive.

benajaero commented 7 years ago

You can format your mac to be case sensitive but it might break a lot of things

tjvr commented 7 years ago

it might break a lot of things

Oh, it does! I tried it on my Mac once, it makes Steam and Adobe software very sad...