Various fixes (bis) - Githubissues

doc75 commented 9 years ago

Hello,

I have found that some more fixes were needed:

scale was applied on all types (leading to issues with strings) and even if scale was equal to 1 (leading to conversion of int to float)
mutliple fields fixes done in my last delivery was not following FIT rev 1.7 as it should be handled with an array.
README was containing a small mistake in the usage example.

I have some more fixes in mind, that I will push when I have time for another round of fixes.

All fixes (except README ;-) ) have a spec test associated.

Hope you don't mind receiving multiple pull request along my fixes...

tjwallace commented 9 years ago

Thanks for the fixes @doc75! I've added a few comments, let me know what you think.

doc75 commented 9 years ago

New commits to fix things according to your valuable remarks (except 1 explained in the commented code) I also added a fix for saling of array elements.

Let me know if anything has to be modified.

I will now try to enhance the lib to support dynamic fields (cf. Rev1.7 §4.5) After that it will remain to manage Components (cf. Rev1.7 §4.6), but I am not sure to know how this can be done easily.

tjwallace commented 9 years ago

Thanks @doc75!

tjwallace / fit

Various fixes (bis) #5