tjx666 / open-in-external-app

Open file with external application in VSCode
https://marketplace.visualstudio.com/items?itemName=YuTengjing.open-in-external-app
MIT License
52 stars 9 forks source link

Open Typora failed, 2022 #46

Closed FengZhiheng closed 1 year ago

FengZhiheng commented 1 year ago

Description

I can not open my md files with this plugin.

Extension Version

0.8.4

VS Code Version

image

Extension Settings

"openInExternalApp.openMapper": [ { "extensionName": "md", "apps": [ { "isElectronApp": true, "title": "typora", "openCommand": "C:/Program Files/Typora/Typora.exe" } ] }, ],

Logs, Screenshots, Screen Recording etc

parsed extension name: md matchedConfigItem: { "extensionName": "md", "apps": [ { "isElectronApp": true, "title": "typora", "openCommand": "C:/Program Files/Typora/Typora.exe" } ] } Opened file is: "c:\Users\XXX\Documents\GitHub\X\source\about\index.md" Open file by vscode builtin api

tjx666 commented 1 year ago

If you want to open md file by typora, you need to set typora as windows default app to open md file.

FengZhiheng commented 1 year ago

If you want to open md file by typora, you need to set typora as windows default app to open md file.

I have already set typora as default app to open md files. But it is still not work for me.

image

The output as follow:

parsed extension name: md
matchedConfigItem:
{
    "extensionName": "md",
    "apps": [
        {
            "isElectronApp": true,
            "title": "typora",
            "openCommand": "C:\\Program Files\\Typora\\Typora.exe"
        }
    ]
}
Opened file is: "c:\Users\XXX\Documents\GitHub\ZhihengBlog\source\_drafts\小结.md"
Open file by vscode builtin api

My system is win11. Thank you very much~

jamesfancy commented 1 year ago

It's cannot work in current version

But it works in older version. I am not sure to know the version since I haven't use it in several monthes.


Typora is already set as default application for .md files so I can open it by double click in windows explorer.

Here is my settings:

    "openInExternalApp.openMapper": [
        {
            "apps": [
                {
                    "isElectronApp": true,
                    "title": "typora"
                }
            ],
            "extensionName": "md"
        }
    ],
tjx666 commented 1 year ago

@FengZhiheng @jamesfancy VSCode On windows doesn't support to open file which file name includes none-ascill-character

For validate, you can rename your file name to readme.md, ant try to open again

FengZhiheng commented 1 year ago

@FengZhiheng @jamesfancy VSCode On windows doesn't support to open file which file name includes none-ascill-character

For validate, you can rename your file name to readme.md, ant try to open again

It is still not work for me. The log information as following:

parsed extension name: md
matchedConfigItem:
{
    "extensionName": "md",
    "apps": [
        {
            "isElectronApp": true,
            "title": "typora",
            "openCommand": "C:\\Program Files\\Typora\\Typora.exe"
        }
    ]
}
Opened file is: "c:\Users\FengZhiheng\Documents\GitHub\ZhihengBlog\source\_drafts\testConclusion.md"
Open file by vscode builtin api

Nothing happened.

jamesfancy commented 1 year ago

@FengZhiheng @jamesfancy VSCode On windows doesn't support to open file which file name includes none-ascill-character

For validate, you can rename your file name to readme.md, ant try to open again

In my case, all characters in path and filename are ASCII (refer to the picture below). It cannot work yet.

image


VSCode udpate to 1.74.2 now, Open in External App v0.9.0

Version: 1.74.2 (user setup) Commit: e8a3071ea4344d9d48ef8a4df2c097372b0c5161 Date: 2022-12-20T10:29:14.590Z Electron: 19.1.8 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0.22000 Sandboxed: No


The log:

open with configItem:
{
    "apps": [
        {
            "isElectronApp": true,
            "title": "typora"
        }
    ],
    "extensionName": "md"
}
opened file is: "d:\James\Workspace\viyi-strings\README.md"
open file by vscode builtin api

I tried use start README.md in powershell. It worked well. The file was opened by Typora.

tjx666 commented 1 year ago

@jamesfancy @FengZhiheng please try latest version

FengZhiheng commented 1 year ago

@jamesfancy @FengZhiheng please try latest version

Excellent job! It works now, thank your very much!

jamesfancy commented 1 year ago

@jamesfancy @FengZhiheng please try latest version

It works. Excellent! Thank you!