tjx666 / open-in-external-app

Open file with external application in VSCode
https://marketplace.visualstudio.com/items?itemName=YuTengjing.open-in-external-app
MIT License
52 stars 9 forks source link

Can't open jpg? #53

Open Hifilo opened 1 year ago

Hifilo commented 1 year ago

Description

Hello. Using WSL, I can't seem to open jpgs with this extension. I tried 2 different settings (individually). Neither seemed to get any response from right click menu

Extension Version

v0.9.7

VS Code Version

Version: 1.76.2 (user setup) Commit: ee2b180d582a7f601fa6ecfdad8d9fd269ab1884 Date: 2023-03-14T17:55:54.936Z Electron: 19.1.11 Chromium: 102.0.5005.196 Node.js: 16.14.2 V8: 10.2.154.26-electron.0 OS: Windows_NT x64 10.0.19045 Sandboxed: Yes

Extension Settings

{
  "openInExternalApp.openMapper": [
    {
      "extensionName": "jpg",
      "apps": [
        {
          "title": "open image",
          "shellCommand": "nomacs ${file}"
        },
        {
          "title": "open image",
          "openCommand": "C:\\Program Files\\JPEGView\\JPEGView.exe"
        }
      ]
    }
  ]
}

Logs, Notifications, Screenshots, Screen Recording etc

nothing happened.

tjx666 commented 1 year ago

please provide the log info:

image
Hifilo commented 1 year ago

this what shows in output when I try to open

language: en
active extension in wsl remote environment
parsed args: [
    {
        "$mid": 1,
        "path": "/home/wavey1/repos/signupform/img/SideImage.png",
        "scheme": "file"
    },
    null
]

edit: I realized in this instance I tried to open a png file, but I also tried with a jpg, and the same issue occurred.

language: en
active extension in wsl remote environment
parsed args: [
    {
        "$mid": 1,
        "path": "/home/wavey1/repos/packages/admindashboard/img/profile3.jpg",
        "scheme": "file"
    },
    null
]

This is the settings I have set in json:

{
"openInExternalApp.openMapper": [
    {
      "extensionName": ["jpg","png"],
      "apps": [
        // {
        //   "title": "open image",
        //   "shellCommand": "nomacs ${file}"
        // }
        {
          "title": "open image",
          "openCommand": "C:\\Program Files\\JPEGView\\JPEGView.exe"
        }
      ]
    }
  ]
}
tjx666 commented 1 year ago

can you try the latest version?

Hifilo commented 1 year ago

Hi, unfortunately I can't test at the moment. WSL has been having some systemd related graphics/logging issues so i disabled it for now.