search

tjx666 / vscode-classic-experience

Restore familiar VSCode keybindings in Cursor editor. Smooth transition for VSCode users.
https://marketplace.visualstudio.com/items?itemName=YuTengjing.vscode-classic-experience
MIT License
10 stars 1 forks source link

Add Windows and Linux Support for ctrl-k #5

Open markjfisher opened 2 days ago

markjfisher commented 2 days ago

I'm not sure why https://github.com/tjx666/vscode-classic-experience/issues/2 was closed, but this extension is not working with windows pressing ctrl-k to delete a line (for example)

Instead I get the cursor pop up: image

Please add support for windows/linux keybindings. Thanks.

DK013 commented 2 days ago

Same issue here

tjx666 commented 1 day ago

I don't have windows computer, would you help provide some information to help debug?

  1. disable this extension, restart vscode and run command Preferences: Open Default Keyboard Shortcuts (JSON)(ctrl + shift + p` to open command palatte), provide me the json content
  2. enable this extension, run the command again, and provide me the json content again
image

@markjfisher @DK013

markjfisher commented 1 day ago

keybindings.json

tjx666 commented 1 day ago

@markjfisher @DK013 please try latest version v1.0.0

cursor extension market is slow than vscode extension market, maybe need to wait some minutes to see latest version.

markjfisher commented 1 day ago

I'll try it as soon as it shows. Still showing 0.1.1 at the moment.

markjfisher commented 1 day ago

It shows in the list if you pick specific version, just not in the changelog...

markjfisher commented 1 day ago

delete line is working in 1.0.0, thanks.

tjx666 commented 1 day ago

@markjfisher Terminal can be clear by ctrl + k ?

markjfisher commented 1 day ago

Yes, I typed something on the cmd line (I use msys2), pressed ctrl-a, ctrl-k and it went to start of line and deleted to the end of the line. did same half way across the line (alt-b to move backwards a couple of words), typed ctrl-k and it delete to the end of line as I expected.

tjx666 commented 1 day ago

thanks for help debug

DK013 commented 23 hours ago

@tjx666 some issues still persist. like the combinations of ctrl+K commands still doesn't work. for example: comment: CTRL+K CTRL+C uncomment: CTRL+K CTRL+U etc.

tjx666 commented 22 hours ago

@DK013 I will fix it tonight, cursor map some the ctrl + k to ctrl + m on windows, which is different with cmd + k mapped to cmd + r on macos.

image
tjx666 commented 22 hours ago

@DK013 Can you help provide the json after run command Preferences: Open Default Keyboard Shortcuts (JSON)?

iscodingeasyornot commented 13 hours ago

Cursor mod said

In Cursor, Cmd/Ctrl+K is used for the inline edits. We therefore changed the keychord leader key to be Cmd+R on Mac and Ctrl+M on Windows and Linux. For example, “Unfold all” is Cmd+R Cmd+J on Mac and Ctrl+M Ctrl+J on Windows and Linux.

so on Windows or Linux the leader key is ctrl+M instead of R. And when I want to switch theme I found ctrl+k ctrl+t not working, search 'theme' on the page found the plugin binds ctrl+k windows+t, which should be ctrl+t image