search

tk0miya / testing.postgresql

Apache License 2.0
291 stars 46 forks source link

Windows compat #7

Closed za-creature closed 8 years ago

za-creature commented 8 years ago

Unfortunately, I can't test this atm as master seems to be a WIP so merging this is probably not a good idea right now.

Can you tag me once you're done refactoring and are prepping a release so I can update and test my code?

za-creature commented 8 years ago

Tests pass now. My original assumption (master is not production-ready) was caused by:

https://github.com/tk0miya/testing.postgresql/blob/master/src/testing/common/database.py#L132

Which I assumed was a WIP as there is no such method in the entire codebase and an attempt is made to run code after exec* returns, which in C would only happen on error, but python will convert said errors into exceptions so that's basically unreachable code.

Additionally, I couldn't figure out how is this not a deadlock and assumed the code is not yet ready. Only later did I find the actual implementation in the testing.postgresql module.

tk0miya commented 8 years ago

@za-creature LGTM!

Now, I splitted the package to testing.postgresql and testing.common.database. And I merge your code into these packages. In Linux and MacOS, it works fine. But I don't have any windows environment. Could you try it in your environement? I'd commit them at windows_support branch in both repositories.

tk0miya commented 8 years ago

Now I merged windows_support branch. Please try it. Thanks,