tk3369 / SASLib.jl

Julia library for reading SAS7BDAT data sets
Other
34 stars 7 forks source link

Inconsistent naming of `:nrows` and `.row_count` #33

Closed xiaodaigh closed 6 years ago

xiaodaigh commented 6 years ago

When I try to read a file incrementally I wanted to looked at the number of rows and then decide how many to read in.

I can open a handle

handler = SASLib.open("data.sas7bdat")

and I was expecting one of the below to work

size(handler)
nrow(handler)
handler.nrows
handler[:nrows]

but the name is actually

handler.row_count

which seems inconsistent with how these things are named elsewhere, namely :nrows

tk3369 commented 6 years ago

The Handler object was never meant to be accessed directly. The proposed Metadata structure should make it more user friendly. See sample usage of the metadata function in Object Design for Metadata and Results

tk3369 commented 6 years ago

Also see #29

tk3369 commented 6 years ago

PR #36 will address this issue. Closing.