search

tk421storm / masksWithHats

Rimworld Mod - allow masks with hats (that dont cover face)
1 stars 0 forks source link

Vanilla Ideology Expanded Compatibility #2

Open HappyGingerWolf opened 4 weeks ago

HappyGingerWolf commented 4 weeks ago

I noticed that the anonymity meme from VIE behaves differently with this mod enabled, and looking at the old changelogs I'm guessing that you set the check for a covered face to use the face cover slot instead of the head slot, so masks would still work?

The problem is, now clothing in the head slot that covers the face, like helmets and ceremonial hoods, are no longer considered valid for the anonymity meme, when they should be.

I think the fix would be to check both slots, not just face cover, but I'm not sure how easy that would be to implement

tk421storm commented 3 weeks ago

ack i bet you're right. my transpiler right now just replaces "FullHead" with "FaceCover", when it should probably do OR. or maybe it has to have a completely different method to determine face coverage.

hopefully have some time in the near future to fix this!

tk421storm commented 3 weeks ago

@HappyGingerWolf did you happen to check changing the mod order? this first vs idelogy first?

HappyGingerWolf commented 3 weeks ago

Thanks for the response, obviously it's not a big rush to fix, this mod still works great Changing the mods order had no effect on the behaviour, I tried both ways

The most reliable way to check anonymity would be to check all clothing slots to see if the eyes, nose, and jaw are covered, but that's probably something the vanilla expanded team should do, it's not really specific to this mod