search

tkaitchuck / aHash

aHash is a non-cryptographic hashing algorithm that uses the AES hardware instruction
https://crates.io/crates/ahash
Apache License 2.0
986 stars 94 forks source link

Increase the MSRV presubmit checks to include multiple architectures #197

Closed tkaitchuck closed 5 months ago

alamb commented 6 months ago

https://github.com/tkaitchuck/aHash/actions/runs/7449693417/job/20266892686?pr=197#step:5:1

Seems to imply it just installed 1.60 in addition to the master build already installed

Maybe you need to change 

  cargo check --target armv7-unknown-linux-gnueabihf

To explicitly mention the tool chain like 

  cargo +1.60 check --target armv7-unknown-linux-gnueabihf

FWIW we use cargo msrv to check this in datafusion

https://github.com/apache/arrow-datafusion/blob/746988a7e5c9f256c3b24ab7e3f30ffd90d542a0/.github/workflows/rust.yml#L546-L568

tkaitchuck commented 6 months ago

It runs rustup default 1.60.0 is this insufficient?

tkaitchuck commented 6 months ago

I added this, everything is still passing...

tkaitchuck commented 5 months ago

It looks like it used to pass with 1.60 but then failed with 1.71 So the command was correct, it was just a discrepancy in what rust supported.

alamb commented 5 months ago

🎉