search

tkaitchuck / aHash

aHash is a non-cryptographic hashing algorithm that uses the AES hardware instruction
https://crates.io/crates/ahash
Apache License 2.0
1.03k stars 101 forks source link

git source unaligned with crates.io release #224

Closed jonassmedegaard closed 6 months ago

jonassmedegaard commented 6 months ago

Git tag v0.8.11 contains code with a Cargo.toml file declaring version as 0.8.10. Code is tagged on the same date as crates.io began offering version 0.8.11 which seems to be missing from git source.

I guess it was a simple mistake of pushing untracked code to crates.io...

tkaitchuck commented 6 months ago

It was pushed from the 0.8 release branch.

tkaitchuck commented 6 months ago

You can see the exact commit the release is based on in the release section: https://github.com/tkaitchuck/aHash/releases

jonassmedegaard commented 6 months ago

I see the branch now, yes. For some reason my local clone, updated with git fetch <the_git_repo> --tags, failed to fetch the tag v0.8.11 till now, which lead me to miss that branch.

Sorry for the noise.

jonassmedegaard commented 6 months ago

Ahh, no, the tag was there all along, and my point is that the contents is not matching: See https://github.com/tkaitchuck/aHash/compare/v0.8.10...v0.8.11 how the version number in Cargo.toml is changed not to 0.8.11 but to 0.8.10.

jonassmedegaard commented 6 months ago

Seems you accidentally tagged HEAD of master branch, instead of HEAD of the release-0.8 branch.