Closed Foldex closed 1 year ago
As it turns out, we can just use good old chrome remote debugging to inspect the new overlay.
Instructions:
8080
(Syncthing, etc)-cef-enable-debugging
argument e.g. steam -cef-enable-debugging
chrome://inspect/#devices
in your Chromium based browserDiscover network targets
, make sure localhost:8080
is presentAs a side note: It seems SFP and Millenium are already using remote debugging to regain lost functionality via injection. While I'm sure encouraging end users to abuse debugging features to enable arbitrary code injection has some attached implications, figured it's at least worth noting here.
@Foldex Can you add a web extra for the notification's location? I've seen a lot of people editing steam.styles to change the location.
Can you add a web extra for the notification's location? I've seen a lot of people editing steam.styles to change the location.
steam.styles
doesn't exist anymore. So I don't think it'd be possible, barring client hackery.
The new UI deals with hover elements like context menus/tooltips/notifications by compositing tiny webpages at specific locations. All CSS has control over is the elements within that page, not where the page itself is placed. Trying to move elements past where they spawn just winds up cutting them off.
Added Initial Support for the In-Game Overlay and Notifications, probably missing stuff but it's just a first pass.
Some random notes:
hey, sorry if you already know about this, but the tittle bar buttons of some of the "apps" in the overlay aren't correct:
and before these new commits since 2 weeks ago you could use the buttons in the tittle bar of the notes app, even though the buttons weren't in the spot you needed to click it worked, but now you can't interact with it at all, other apps works fine tho
the tittle bar buttons of some of the "apps" in the overlay aren't correct:
Thanks for letting me know, those icons should be fixed now.
Also added a Web Extra for hiding the url bar, since apparently that option is gone from the beta.
Since it seems like the beta might remain a beta for a good while longer, I've added support for installing from this branch to AdwSteamGtk.
Release should hit flathub in a few hours.
Game Properties are back to looking remotely Adwaita-ish:
![ss-2023-05-31_20:05:33](https://github.com/tkashkin/Adwaita-for-Steam/assets/47908676/1ddce5d6-0bb8-479d-a13d-9ebdb5f88bd0) ![ss-2023-05-31_20:06:12](https://github.com/tkashkin/Adwaita-for-Steam/assets/47908676/3d94be2e-ae54-4b1b-becc-fd5f66a5830a) ![ss-2023-05-31_20:06:37](https://github.com/tkashkin/Adwaita-for-Steam/assets/47908676/440f8cfb-e67e-4fd9-a202-757749de6ff4)
![ss-2023-05-31_20:07:11](https://github.com/tkashkin/Adwaita-for-Steam/assets/47908676/cb983a43-443d-4ef0-bf95-1af6aedb0847) ![ss-2023-05-31_20:07:17](https://github.com/tkashkin/Adwaita-for-Steam/assets/47908676/be7de2d4-4811-426f-adc7-3e8489e0cd0f) ![ss-2023-05-31_20:07:25](https://github.com/tkashkin/Adwaita-for-Steam/assets/47908676/29e2458c-88f3-43c2-a71f-581d224b9fb3)
There are a few sections that I'm unable to make look like a properly attached Adwaita Preference Row. Would be easy if they belonged to the same parent node, but unfortunately they belong to entirely separate sections. Gonna hit it with the old "It's probably good enough".
![image](https://github.com/tkashkin/Adwaita-for-Steam/assets/47908676/6548a17b-8a75-4b70-adcc-ec93fdb6c23d) ![image](https://github.com/tkashkin/Adwaita-for-Steam/assets/47908676/2b21b901-9114-4044-9903-e54580fbbeb4)
Install Dialog done:
Overlay List Mode done:
Steam Settings is partially cleaned up, though it's not quite Adwaita. Due to how many sub layouts are used within this dialog, most of which using generic classes, getting things to look like Adwaita Preference Rows without breaking another view is likely going to be a pain:
For those who don't like the Adwaita styled Top Bar, added a web extra that reverts to the Original Steam Bar:
apologies if you already know this, but the steam close button (middle) does not look like it should, at least compared to native (themed using gradience) gtk4 applications
the steam close button (middle) does not look like it should
Latest Beta Client made some changes to the Window Controls. Should be fixed by https://github.com/tkashkin/Adwaita-for-Steam/pull/150/commits/ace865de9abc01e9fcee13284ce58be67a64c4cb
@tkashkin New UI is out of Beta, so marking this as ready to review.
Figured I might as well open it.
TODO: