search

tkashkin / Adwaita-for-Steam

A skin to make Steam look more like a native GNOME app
MIT License
1.06k stars 26 forks source link

Not all color themes are updated for v2 #242

Closed chomskysfavefive closed 2 months ago

chomskysfavefive commented 2 months ago

Dracula theme does not apply. Everything about my hardware and software is the same as yesterday, the only thing that changed was that I updated AdwSteamGTK to 2.0.

Steps to reproduce:

  1. Exit Steam.
  2. Install Dracula theme
  3. Open Steam to a generic Adwaita theme without Dracula color palette. This is not expected behavior.
chomskysfavefive commented 2 months ago

The libraryroot css file shows that the Dracula theme is applied, but it's not. The colors.css seems like it's the generic Adwaita palette, not the Dracula palette.

chomskysfavefive commented 2 months ago

Also the web page part of the client is not themed at all.

Screenshot from 2024-05-08 00-39-05

Foldex commented 2 months ago

Looks like most themes haven't been updated to the new format yet. Aside from the below, the rest are going to be broken.

Updated Themes Adwaita Breeze Canta Catppuccin-Frappe Yaru

chomskysfavefive commented 2 months ago

Copy that, thanks so much!

chomskysfavefive commented 2 months ago

Using the updated themes now as a demo. Fantastic work. The hover menus near the hamburger menu button are working great.

eylles commented 2 months ago

i cobbled a template for using with pywal on https://github.com/tkashkin/Adwaita-for-Steam/issues/205#issuecomment-1894783285 and i'm currently prototyping a python script to read a json file with colors from either pywal or gradience (that part of the script is already done) and was working on cobbling a template for the css for said script, if you would be so kind to direct me which is the correct css to use as template OR if the custom css is no longer going to be supported an example of how to add another color theme (if there is more to it than creating a directory under colorthemes with the right css)

tkashkin commented 2 months ago

@eylles

which is the correct css to use as template

Either adwaita/css/_root/colors.css or adwaita/colorthemes/adwaita/adwaita.css, both are the same. They define all theme colors which are mostly taken from the libadwaita stylesheet. There are a few other variables defined in adwaita/css/_root.

how to add another color theme (if there is more to it than creating a directory under colorthemes with the right css)

Create adwaita/colorthemes/$name/$name.css and it should be detected by the installer script.

eylles commented 2 months ago

@tkashkin thanks for your input, hope to have it ready for the weekend.