Fixes the unexpected behaviour on Windows that causes the args.target always to be overwritten, effectively disabling the --target argument on Windows and requiring manual edits to the constants to change the target destination path.
This PR also changes the default behaviour on non-Windows systems, so that default values are no longer being strictly enforced when additional or explicit parameter values have been given for the --target argument.
How To Reproduce (Current Codebase)
Call install.py with the --target argument on Windows and supply a custom path.
Output the contents of args.target.
The supplied custom path was lost, defaulting to the value windows.
How To Test (Pull Request)
Same steps as for the reproduction.
On non-Windows systems:
2.1. Do not specify the --target argument.
2.2. This will default to the values normal and flatpak.
2.3. Specify values for the --target argument (i.e. --target "flatpak" "/tmp/steam").
2.4. Check args.target, only the specified values are present.
Short Description
Fixes the unexpected behaviour on Windows that causes the
args.targetalways to be overwritten, effectively disabling the--targetargument on Windows and requiring manual edits to the constants to change the target destination path.This PR also changes the default behaviour on non-Windows systems, so that default values are no longer being strictly enforced when additional or explicit parameter values have been given for the
--targetargument.How To Reproduce (Current Codebase)
install.pywith the--targetargument on Windows and supply a custom path.args.target.windows.How To Test (Pull Request)
--targetargument. 2.2. This will default to the valuesnormalandflatpak. 2.3. Specify values for the--targetargument (i.e.--target "flatpak" "/tmp/steam"). 2.4. Checkargs.target, only the specified values are present.