windowcontrols/hide-close is missing buttons completely

tkashkin / Adwaita-for-Steam

A skin to make Steam look more like a native GNOME app

MIT License

1.09k stars 25 forks source link

windowcontrols/hide-close is missing buttons completely #256

Closed pinbuck closed 2 months ago

pinbuck commented 2 months ago

Screenshot_20240625_015218 Expected: minimize, maximize, and close button apparent. A recent update on steam seemed to break it. Omitting windowcontrols/hide-close leaves the X button there like normal.

tkashkin commented 2 months ago

hide-close is supposed to hide the close button. Other buttons are already hidden by default. The bug here is that it should also override the right margin.

Perhaps this extra should be called hide-all or none to make it more obvious.

pinbuck commented 2 months ago

ah oops, I realized my mistake. I was messing with the text in the document diagnosing steam skin breakage one day. windowcontrols/right-all is what I had intended to put there.