tkashkin / GameHub

All your games in one place
https://tkashkin.github.io/projects/gamehub
GNU General Public License v3.0
2.24k stars 128 forks source link

Search results for SteamGridDB are missing #249

Closed Lucki closed 5 years ago

Lucki commented 5 years ago
Expected behavior

Grid images from SteamGridDB are shown as well as JinxSGVI results.

Actual behavior

Only JinxSGVI results are shown if there are any.

Steps to reproduce

Click in any games settings dialog on the download button next to the image-url entry field. Let's take a popular one for testing: Diablo III grafik

Version and environment
Version: 0.14.0-164e55c-makepkg
Branch:  makepkg
Commit:  164e55c (164e55c87614657b6a9345b919cefc844a44bf53)
Distro:  Arch Linux
DE:      GNOME
Bonus feature request:

Bring back the clickable links to quickly adjust the search or try further if the search result for that service is missing. (steamgriddbs main page, jinxsgvi since it's very picky about the name, and the google search was useful in the past too)

tkashkin commented 5 years ago

GET https://steamgriddb.com/api/v2/search/autocomplete/<anything>:

{
    "success": false,
    "errors": ["Authentication Required"]
}

It seems SteamGridDB suddenly started to require authentication. There were nothing about API keys a few days ago when I was implementing this :confused:.

tkashkin commented 5 years ago

It should be fixed.

Bring back the clickable links

Links are readded.

jinxsgvi since it's very picky about the name

You can change game name in preferences dialog and reopen popup. It should search for images with new name. (SteamGridDB doesn't use name for Steam games and searches by appid)

Lucki commented 5 years ago

That's great! I've noticed the top of the popup gets cut off from the window on small settings pages (usually on games provided by steam): grafik

tkashkin commented 5 years ago

@Lucki

popup gets cut off

It should be fixed, let me know if not.

Lucki commented 5 years ago

@tkashkin I'm sorry but now it's cut off at the bottom. grafik

tkashkin commented 5 years ago

@Lucki now it should be fixed.

Lucki commented 5 years ago

It is!