Fix executable permissions for some games (distributed in zip files)

tkashkin / GameHub

All your games in one place

https://tkashkin.github.io/projects/gamehub

GNU General Public License v3.0

2.25k stars 128 forks source link

Fix executable permissions for some games (distributed in zip files) #42

Closed neuromancer closed 6 years ago

neuromancer commented 6 years ago

Some lazy game developers in Humble Bundle distribute their games in zip files, which do not preserve the executable permissions (e.g. Cubemen) . A quick fix is to execute chmod +x in the the selected executable file once the installation is over.

tkashkin commented 6 years ago

It should already do that.

neuromancer commented 6 years ago

According to the that code, the previous line calls file-roller (or the MojoSetup installer) and could be taking a little longer than expected to install. Maybe a race condition is causing that the chmod +x is not applied to all the files?

tkashkin commented 6 years ago

yield will stop execution of this method while command runs. But it's probably a good idea to move chmod a bit lower after next try/catch block since it's moving files from game/some_unwanted_dir/* to game/*.

tkashkin commented 6 years ago

Try 8dc569a.

neuromancer commented 6 years ago

Fixed!