Run wineboot with tweaks

tkashkin / GameHub

All your games in one place

https://tkashkin.github.io/projects/gamehub

GNU General Public License v3.0

2.23k stars 129 forks source link

Run wineboot with tweaks #533

Closed o-schneider closed 3 years ago

o-schneider commented 3 years ago

Hi,

I recently started using GameHub and tried some gaming workflow and tweaks. I notably tried to create tweaks to enable/disable esynf/fsync when using the system's wine installation, and found out that using the tweak crashed wine. I narrowed the issue to the fact that the env var wasn't passed on when running wineboot, so I added the tweaks enabling to wineboot execution.

It might be a little random as I've not created an issue or anything, but as I couldn't find contribution instructions, I decided to just go ahead wit the PR and see. Tell me if I did anything wrong and if there's any process I should follow. :)

tkashkin commented 3 years ago

The most recent development version is in the refactoring branch and it seems this issue should be fixed there.

o-schneider commented 3 years ago

Ok I guess that closes the PR. I'd like to help but don't really know how/where to start. Is there any discussion channel somewhere, any priorities?

tkashkin commented 3 years ago

Is there any discussion channel somewhere?

Currently the main and only discussion channel is this repo (issues and discussions). I could setup something else like a Discord server but it's probably enough for now.

I'd like to help but don't really know how/where to start. any priorities?

The main priority right now is to finish refactoring the codebase, implement some planned features, test everything, fix bugs, and eventually release 1.0. I don't think you can help with that, at least until I push my local changes.

There are some things you can help with now:

Translations if you know languages that don't have translations or are not complete
Documentation - there is some, but it is very incomplete
Testing (especially refactoring branch)
Answering questions in issues/discussions if you know the answer
Ideas and feature requests

o-schneider commented 3 years ago

Ok thanks. Consider pushing your code soon if that's possible. I tried a bit the refactoring branch and found some issues and found some issues but I'd prefer to be sure to not report or suggest fix on stale code. For instance, the issue I tried to fix with this PR that doesn't seem fixed after all, at least in the current refactoring branch state. On the other hand, there a huge amount of great improvements, like the new details window, better presentation of wine versions, tweaks and so on. And no more dialogs, which is kinda a big deal for us tiling WM users. ^^

tkashkin commented 3 years ago

I am currently rewriting Database, FS and GameSource and that's a lot of changes so it will probably take some time before it at least compiles and I can push it.

You can probably start working on something if you want and if it's small and doesn't rely on Database, FS or GameSource too much.