tkashkin / GameHub

All your games in one place
https://tkashkin.github.io/projects/gamehub
GNU General Public License v3.0
2.23k stars 129 forks source link

Add confirmation dialogue to uninstall/remove options #537

Open Acetsetebos opened 3 years ago

Acetsetebos commented 3 years ago

It's way too easy to accidentally uninstall games through the right-click drop down menu or the uninstall button in the list view, it would be nice to have a simple yes/no confirmation pop-up to prevent accidentally uninstalling games.

michaelneverwins commented 3 years ago

Some options when uninstalling would also be appreciated.

Prior to installing GameHub, I had already installed one of my Windows-compatible GOG games just by downloading and running its installer with Wine, so of course GameHub didn't detect that it was installed. When I clicked the "install" button in GameHub, I saw the "import" option, so I used that to give GameHub the location of the already-installed game. As a test, I then tried the "uninstall" function for that game. Sure enough, GameHub recursively deleted the game's directory (without, as you've pointed out, any confirmation prompt), despite the fact that the install wasn't managed by GameHub in the first place.

If I actually install a game via GameHub, then I would expect to be able to fully uninstall it via GameHub. However, when it comes to previously installed GOG games which are simply imported into GameHub after the fact, I would expect an option to undo the import without actually deleting the game itself, similar to the "remove" option for manually added games not associated with a specific platform.

When I add an arbitrary executable using the "add game" option, I can then remove that entry from GameHub without anything being deleted, which is good. In that case, however, I would like an option to delete any additional files that were created by GameHub to support its own functions, namely the _gamehub folder that gets created automatically for the Wine prefix.

marhkb commented 3 years ago

Accidentally deleted my Witcher 3 installation irretrievably, just because of one wrong click.