tkashkin / GameHub

All your games in one place
https://tkashkin.github.io/projects/gamehub
GNU General Public License v3.0
2.23k stars 129 forks source link

Fix Proton > 5.13 not starting #596

Closed Lucki closed 2 years ago

Lucki commented 2 years ago

Logging adjustments

The logging requires SteamGameId to be set.

https://github.com/ValveSoftware/Proton/blob/50b4c8785f389f0840bfc6a9ee3f233c9de2da48/proton#L953-L954 :

if not "SteamGameId" in os.environ:
    return False

Old code for comparison: https://github.com/ValveSoftware/Proton/blame/f27ab32edb1517fcd79665ced44cad91dedfe36c/proton#L831-L857

I removed the debug flags for performance reasons in this PR.

Syncing calls to wineboot

There's another error coming up in 6.3 which isn't problematic in 5.13:

err:esync:esync_init Failed to open esync shared memory file; make sure no stale wineserver instances are running without WINEESYNC.

This can be worked around by calling waitforexitandrun instead of just run but it would probably be better to solve the problem instead: With an already running wineserver the sync options have to match with the calls later on by Proton. For now it's hardcoding WINEESYNC and WINEFSYNC to the defaults of Proton.


Fixes #593

Lucki commented 2 years ago

Sorry, forgot about dev :/