Folder variables are not working correctly

Franz-Heinz commented 2 years ago

Expected behavior

The use of $root/Installer/GOG/$game and $root/Installer/HumbleBundle/$game for storing the installers should store each game in an own folder.

Actual behavior

Using $root/Installer/GOG/$game and $root/Installer/HumbleBundle/$game for storing the installers does not create game folders for each game but creates a subfolder named '$game'. It seems like '$game' is not recognized as a variable by GameHub

Steps to reproduce

Set $root/Installer/GOG/$game and $root/Installer/HumbleBundle/$game as folders for storing the installers in the GameHub settings. After downloading a game via GameHub check the created folder name.

Version and environment

GameHub 0.16.1-ebb46ff-master Ubuntu 18.04. LTS (all updates installed)

- GameHub
    Version: 0.16.1-ebb46ff-master
    Branch:  master
    Commit:  ebb46ff0b394fbb004e8a3d2bfc4f47410dec18f
- Environment
    Distro:  Ubuntu 18.04.6 LTS
    DE:      ubuntu:GNOME
    GTK:     3.22.30

CartoonFan commented 2 years ago

From what I can see, $game seems to work only in the "Game directory" field; everywhere else, it shows up as a literal $game. But yeah, a fix would feel nice.

EDIT: I made a pull request that hopefully fixes the issue (https://github.com/tkashkin/GameHub/pull/635) :crossed_fingers:

tkashkin commented 2 years ago

Should be fixed by 550226e.

CartoonFan commented 2 years ago

Thanks! I'll give it a try.

tkashkin / GameHub