search

tkawachi / sbt-lock

Gemfile.lock for sbt
75 stars 12 forks source link

prefer "version" extra-attribute over revision #26

Closed nadavwr closed 5 years ago

nadavwr commented 5 years ago

The following snippet, for me, yields lockfiles with version ranges:

 libraryDependencies ++= List(
      "org.typelevel" %% "cats-core" % "1.5.+",
      "org.typelevel" %% "cats-mtl-core" % "0.4.+",
      "org.typelevel" %% "cats-effect" % "1.1.+",
      "org.scalatest" %% "scalatest" % "3.0.+" % Test
    )

...and the output:

//...
      "org.typelevel" % "cats-core_2.12" % "1.5.0",
      "org.typelevel" % "cats-effect_2.12" % "1.1.+",
      "org.typelevel" % "cats-kernel_2.12" % "1.5.0",
      "org.typelevel" % "cats-macros_2.12" % "1.5.0",
      "org.typelevel" % "cats-mtl-core_2.12" % "0.4.+",
//...

Oddly, some versions are fully resolved and others remain as ranges.

I've altered SbtLock.scala to prefer the extra-attribute "version" when available— this seems to solve the problem.