Make realpath (...) and friends properly handle file names with multi-byte characters

tkchia / newlib-ia16

Fork of IA-16 port of Newlib -- added small and medium model support

GNU General Public License v2.0

13 stars 4 forks source link

Make realpath (...) and friends properly handle file names with multi-byte characters #17

Closed tkchia closed 2 years ago

tkchia commented 2 years ago

At least under the Japanese version of MS-DOS, apparently it is very possible for file name components to contain e.g. a "backslash" byte element ('\x5c'), if it occurs as part of a multi-byte character sequence.

realpath (...) and _stat_r (...) should really be updated to handle such cases. Rather than just looking at each byte individually as a character, they should take into account the active DOS code page.

Functions in libi86 should probably also be updated.

tkchia commented 2 years ago

Fixed with

https://github.com/tkchia/newlib-ia16/commit/ceab16068419ab1c34cabc5b1198e55717b6c580, https://github.com/tkchia/newlib-ia16/commit/71945c562b679a5ddaa043aa98641f05e290268c, https://github.com/tkchia/newlib-ia16/commit/d6cd0cb757489eb616c0f3e154f25e30d449e971 on the newlib-ia16 end; and
https://github.com/tkchia/libi86/commit/b36cadf35fbd2d0f0c6ad0248cc30348e45b1524, https://github.com/tkchia/libi86/commit/a8a5d909d4a59785e9971a15f3d7b9077d5c2369, https://github.com/tkchia/libi86/commit/d5bdd4fb563a85ca489b84ad60c875a2e9e48af2, https://github.com/tkchia/libi86/commit/48d0e0e0ef3f529969998cec7bb20a1dbe7dffd3 on the libi86 end.