search

tkchris93 / ForwardThinking

Forward Thinking NIPS 2017
106 stars 26 forks source link

Issues in structure.py and FTDRF_test.py? #6

Open EcoSimIBM opened 6 years ago

EcoSimIBM commented 6 years ago

Hey there,

I tried running the Deep RF and DNN code. I got the DNN code working no problem, but the Deep RF code apparently has a couple issues. In FTDRF_test.py ("y_sp = y_sp.astype('uint8')") seems to fail as ysp was not yet initialized. After commenting that out (it doesn't appear to be used at all), it then fails in structure.py at the line "for tree in models[count].estimators: # make half of the trees completely random Decision Trees" - similar issue (I think) - to me it appears as though the trees have not been generated yet and thus the forest has no attribute "estimators" (the error generated is an AttributeError when trying to iterator over the "esimators" attribute in the RandomForestClassifier).

Is there something I'm missing here?

Thanks,

Ryan

davidkartchner commented 6 years ago

Hi Ryan,

Pardon the slow reply. I found the bug in the code and updated it. The update should be merged back into the repo by the end of the week.

Thanks, David

EcoSimIBM commented 6 years ago

Hello David,

No worries. Sounds good.

Thanks,

Ryan

On Wed, Jan 17, 2018 at 3:35 PM, David Kartchner notifications@github.com wrote:

Hi Ryan,

Pardon the slow reply. I found the bug in the code and updated it. The update should be merged back into the repo by the end of the week.

Thanks, David

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tkchris93/ForwardThinking/issues/6#issuecomment-358436366, or mute the thread https://github.com/notifications/unsubscribe-auth/AfDUj40NjkGdd1qBHpwWnw8ct5tsjI4Wks5tLll1gaJpZM4RLdkA .