search

tkellogg / Jump-Location

Powershell `cd` that reads your mind
MIT License
467 stars 26 forks source link

jumpstat should not reclassify directories with negative weight #23

Closed joj closed 9 years ago

joj commented 9 years ago

I'm assuming here that the only way a directory can get a negative weight is by manually editing it, as stated in the wiki. Please tell me if I'm wrong.

Related to #15, the way I'm excluding the poshgit directory is by assigning it a negative weight. I find this absolutely acceptable, more than the plugin trying to guess that I didn't want it to begin with. The problem is that every time I open the shell, the directory gets reevaluated and back in the list. I think if I assigned a negative weight (if that's the only way to get a negative weight) it implies I don't ever want to jump to that folder. It should be kept forever negative, never readded.

joj commented 9 years ago

BTW, allowing exclusion of directories may be redundant with this fix. Maybe add a jumpstat -del which simply assigns a negative weight?

tkellogg commented 9 years ago

@joj yes, you are correct that this has to be manually edited. I'll make sure a command is added and documented to assign a negative weight. Thanks for reporting!

vors commented 9 years ago

I think -exclude is more appropriate name for the parameter.

joj commented 9 years ago

+1 to exclude.

vors commented 9 years ago

duplicate for #15