search

tkellogg / MongoDB.FSharp

Silent utilities to make the official MongoDB driver feel natural to work with in F#
http://nuget.org/packages/MongoDB.FSharp/
Other
64 stars 16 forks source link

Updated MongoDB Driver and FSharp Runtime #9

Open nukedbit opened 9 years ago

nukedbit commented 9 years ago

Hi i have updated to new shining mongodb driver :), and also with the last F# runtime, let me know if you like it or if i should improve something

tkellogg commented 9 years ago

Hi Sebastian,

I apologize for taking so long to get around to this PR. I'm not ready to merge this quite yet as there's a few outstanding issues I'd like to see resolved first.

I'm not particularly happy that one of the changes wipes out my name as owner. If you really intend to commit time to this project, I'm open to discussing what we can do, but I assure you that nothing of the sort will happen in this PR.

As for the other changes, I've just been skimming the code so I haven't been able to thoroughly read through the changes like I should. Still, there seems to be some issues I'd like to see resolved before this gets merged.

Thanks again for taking the time to contribute, I do appreciate the patience it takes.

nukedbit commented 9 years ago

Hi Tim Don't worry for the timing i understand everyone has it's priorities :), sorry for the typos but i've been only one month on F# on a greenfield project,i can keep improve it on my fork based on your suggestion, and maybe with time we can merge it back, if you like to help me out figure out where i'm wrong :) we can work together, sorry for the owner error, i really meant to add me as author of the changes not as the owner.

tkellogg commented 9 years ago

On further inspection, perhaps those async blocks in df0505c were a good idea. It just looked strange when I looked at them first -- up to you if you want to un-revert.

What you have looks pretty good, but it's also a major change so I'm going to take my time merging it in.

nukedbit commented 9 years ago

Yes they maybe can simply reading of code, but at the end the code is executed synchronously, maybe i could readd them later. Yes is a very breaking change maybe we should publish it as a new version specifically for the new driver? currently i have renamed the package to MongoDB.Driver.FSharp so it can match the currently naming of the driver and also so i can use it internally without conflicts.