search

tkem / mopidy-dleyna

Mopidy extension for playing music from Digital Media Servers
Apache License 2.0
18 stars 5 forks source link

remove deprecated option in default config #53

Closed anthonydahanne closed 8 years ago

anthonydahanne commented 8 years ago

This option : upnp_lookup_limit was not supported with latest version and disabled modipy-dleyna at startup of modipy

2016-07-15 16:08:32,905 INFO [2894:MainThread] mopidy.__main__: Disabled extensions: dleyna
2016-07-15 16:08:32,913 WARNING [2894:MainThread] mopidy.__main__: Found dleyna configuration errors, the extension has been automatically disabled:
2016-07-15 16:08:32,921 WARNING [2894:MainThread] mopidy.__main__:   dleyna/upnp_lookup_limit unknown config key.
2016-07-15 16:08:32,928 WARNING [2894:MainThread] mopidy.__main__: Please fix the extension configuration errors or disable the extensions to silence these messages.
coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 50.926% when pulling 54c8c32d015b59da167a2bad2e6bd9e9e3ffa00c on anthonydahanne:config-remove-upnp_lookup_limit into d59739a2df0e6e8d41d62b276ad343a588986e4a on tkem:master.

tkem commented 8 years ago

Huh? How did you install Mopidy-dLeyna?

anthonydahanne commented 8 years ago

I installed via apt-get install to get all deps And then using pip, to make sure I had the latest version

tkem commented 8 years ago

This is strange, cannot reproduce with Mopidy-dLeyna v1.1.1. However, upnp_lookup_limit is not deprecated, but was only added recently, so closing this PR. Feel free to open a bug report if problem persists, please also check version as reported by pip freeze.

anthonydahanne commented 8 years ago

ah ! pip freeze returned : Mopidy-dLeyna==1.0.5