search

tkem / openlap

Slot Car Race Management App for Carrera(R) Digital 124/132
Apache License 2.0
32 stars 24 forks source link

iOS icons must not have transparent background #125

Closed softyde closed 3 years ago

softyde commented 3 years ago

Hi Thomas,

I hope you are well.

after a long time I wanted to update the iOS version again. Everything has worked so far, the sources are excellently maintained, but Apple rejects apps where the icons have transparent backgrounds. I kind of adjusted the icon - you might want to think about a consistent look&feel.

Kind regards Philipp

tkem commented 3 years ago

Hi Philipp,

thanks for the update - so, after Android introducing adaptive icons, Apple also tries to fix something nobody considered broken, too?

Consistent look & feel would be nice, but for now I'll go with anything you come up with for iOS ;-)

Looking at your PR I noticed several new files that were not added to config.xml:

    resources/ios/icon.png
    resources/ios/icon/icon-108@2x.png
    resources/ios/icon/icon-20.png
    resources/ios/icon/icon-20@2x.png
    resources/ios/icon/icon-20@3x.png
    resources/ios/icon/icon-24@2x.png
    resources/ios/icon/icon-27.5@2x.png
    resources/ios/icon/icon-29.png
    resources/ios/icon/icon-29@2x.png
    resources/ios/icon/icon-29@3x.png
    resources/ios/icon/icon-44@2x.png
    resources/ios/icon/icon-86@2x.png
    resources/ios/icon/icon-98@2x.png
    resources/ios/splash/Default-1792h~iphone.png
    resources/ios/splash/Default-2436h.png
    resources/ios/splash/Default-2688h~iphone.png
    resources/ios/splash/Default-Landscape-1792h~iphone.png
    resources/ios/splash/Default-Landscape-2436h.png
    resources/ios/splash/Default-Landscape-2688h~iphone.png

I guess these won't even be included in the iOS app, so I'm wondering whether it's save to delete them or whether <icon> and <splash> entries should be added for these. resources/ios/icon.png seems to be a copy of resources/ios/icon/icon.png and can be removed though, IMHO.

tkem commented 3 years ago

@softy: Thanks for your input, new iOS icons (more "consistent" with Android versions) have been added in master branch.