Adaptions for iOS app - Githubissues

elliot2extreme commented 7 years ago

Generated icons and splash screens for iOS. Size of icon and splash master image were too small for the generation, therefor I scaled them up (dirty)
Adaptions in src/app/app.component.ts to fix speech rate on iOS
Adaptions in src/carrera/data-view.ts to get the app starting in iOS

tkem commented 7 years ago

I think this is a bit much for a single PR, and would be a pain to merge; as it is, it also breaks the build messing with package.json etc., which should be outside its scope. Could you provide a PR with just the code changes? This would also be easier to review, without all the images getting in the way ;-) Regarding images, I guess you mean something like this when running ionic cordova resources ios:

Error: encountered bad status code (400) for https://res.ionic.io/api/v1/transform
body: {"Error":"source image 2208x2208 too small for Default-Portrait@~ipadpro.png, requires at least 2048x2732 source file"}

As you mentioned, just scaling the images is kind of a dirty hack. I'll have a look at the masters and see what I can do next week or so.

tkem commented 7 years ago

You may also want to base you PR on the develop branch, which contains updated dependencies and will be the base for the next release (whenever that is).

elliot2extreme commented 7 years ago

I will rework my push request to two separate commits based on the develop branch.

tkem commented 7 years ago

:+1: I will take care of the image issues ASAP; watch https://github.com/tkem/openlap/issues/82

tkem commented 7 years ago

I had some time available, so I simply added your code changes myself to the develop branch (I'll update the changelog/readme and give contribution later, promise). Please check if this works for you now, and feel free to provide more (but maybe a little smaller) PRs if need be.

tkem / openlap

Adaptions for iOS app #81