tkf / BenchmarkCI.jl

MIT License
53 stars 5 forks source link

Fix CompatHelper so that you don't get a duplicate PR every day #166

Closed DilumAluthge closed 3 years ago

DilumAluthge commented 3 years ago

This PR fixes the CompatHelper config in this repo to use the latest recommend config.

Thus, among other improvements, you won't get a duplicate PR every day.

Since you use GitHub Actions CI, the following line from this PR ensures that CI gets triggered on PRs made by CompatHelper:

COMPATHELPER_PRIV: ${{ secrets.DOCUMENTER_KEY }}
DilumAluthge commented 3 years ago

@tkf It would be great to merge this as soon as possible.

cc: @giordano

DilumAluthge commented 3 years ago

@tkf I've made a few other PRs to update the CompatHelper setup on some of your other repos.

If you want to update the CompatHelper setup on a whole bunch of repos at once, you might consider the MassInstallAction.jl package. E.g.:

julia> using MassInstallAction

julia> workflow = MassInstallAction.compat_helper()

julia> MassInstallAction.install(workflow,
           "tkf";
           token = ENV["MY_GITHUB_TOKEN"],
           cc = ["tkf"],
       )
codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d8df544). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage          ?   67.55%           
=========================================
  Files             ?        3           
  Lines             ?      413           
  Branches          ?        0           
=========================================
  Hits              ?      279           
  Misses            ?      134           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8df544...6a23069. Read the comment docs.

DilumAluthge commented 3 years ago

After merging this PR, I would go through and close all of the currently open CompatHelper PRs. Then, the next time CompatHelper runs, it will only open PRs if they need to be opened.

DilumAluthge commented 3 years ago

From Mergify:

GitHub App like Mergify are not allowed to merge pull request where .github/workflows is changed.

This pull request must be merged manually.