Suggestion: rename `fetch` key within render prop

tkh44 / holen

Declarative fetch for React

MIT License

150 stars 16 forks source link

Suggestion: rename `fetch` key within render prop #19

Open jamesplease opened 6 years ago

jamesplease commented 6 years ago

The fetch method within the render prop shadows globalScope.fetch, which isn't ideal. Although it is nice that it has the same name, it could potentially cause confusion in certain situations.

One idea would be to rename it so as to avoid this problem.

Just a thought. No worries if you're satisfied with the current name :v:

Thanks for reading!

tkh44 commented 6 years ago

This makes sense. I think something simple like doFetch or similar should work for now.

jamesplease commented 6 years ago

:+1: Cool. I'll make a PR. Thanks @tkh44 !