search

tkhq / qos

QuorumOS is a computation layer for running applications inside Trusted Execution Environments (TEEs)
GNU Affero General Public License v3.0
5 stars 2 forks source link

Yml workflow refactor #475

Closed mavrukin closed 2 months ago

mavrukin commented 4 months ago

Summary & Motivation (Problem vs. Solution)

How I Tested These Changes

Pre merge check list

cr-tk commented 2 months ago

@mavrukin is this PR ready to merge?

Looking at the changes, I'm wondering if all intended commits are included.

The commit message of e2d6c350fd1f9c7f4d499115b9b4fadcfb54208a suggests that the separation of checkout_and_setup happens with the goal of running that action only once. I'm assuming that means running it only once while running all three test, format and docs jobs. However, only test is modified, the other two aren't refactored.

In this context, I would have expected the addition of needs: checkout_and_setup and a removal of the Checkout sources and Setup Docker steps on them, too.

mavrukin commented 2 months ago

@mavrukin is this PR ready to merge?

Looking at the changes, I'm wondering if all intended commits are included.

The commit message of e2d6c35 suggests that the separation of checkout_and_setup happens with the goal of running that action only once. I'm assuming that means running it only once while running all three test, format and docs jobs. However, only test is modified, the other two aren't refactored.

In this context, I would have expected the addition of needs: checkout_and_setup and a removal of the Checkout sources and Setup Docker steps on them, too.

Its old and irrelevant, I think sean had done a lot of cleanup and refactoring, far above anything I was going to do