search

tkhq / sdk

Turnkey TypeScript SDK
Apache License 2.0
52 stars 14 forks source link

Fix personal sign parameter #387

Closed zkharit closed 1 month ago

zkharit commented 1 month ago

Summary & Motivation

Submitted by @k-xo 🙌, fixes the personal-sign function which has flipped parameters from the eth-sign function

How I Tested These Changes

Did you add a changeset?

If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run pnpm changeset. pnpm changeset will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).

These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.