tklab-tud / ID2T

Official ID2T repository. ID2T creates labeled IT network datasets that contain user defined synthetic attacks.
MIT License
56 stars 22 forks source link

Feature/attack/drupal scan #118

Closed Abdiiir closed 1 year ago

Abdiiir commented 1 year ago
pepper-jk commented 1 year ago

The commits e97e3eb, a91196a can be squashed into one commit.

e97e3eb and 4662015 should have more descriptive commit messages.

Please try the following format:

e97e3eb

Durpal Scan: <Add the attack>

<description of attack>
<short explanation on how the attack functions>

4662015

Durpal Scan: <use common CMS functionalities>

<which functions are used>
<explain why they are used>
<how does it improve the attack>

Same scheme might be applied to 1282381:

Base Attack: <add common CMS functionalities>

<describe functionalities with reference to function name>
<explain how to use them XOR (at least) give an example>
pepper-jk commented 1 year ago

I like the initiative here. Looks like a reasonably well implemented attack.

Only had time to glance over it though. Hopefully, I will find time to test it myself and review the actual attack implementation soon. In the meantime please go over my requested changes and let me know if you have any questions.

Happy holidays to you.

Abdiiir commented 1 year ago

Hi @pepper-jk ,

Thanks for the review. I appreciate you taking the time.

I will implement the requested changes and force-push.

Happy holidays to you too :))