add new Attack Tests to replace removed hash tests

tklab-tud / ID2T

Official ID2T repository. ID2T creates labeled IT network datasets that contain user defined synthetic attacks.

MIT License

56 stars 22 forks source link

add new Attack Tests to replace removed hash tests #87

Closed pepper-jk closed 5 years ago

pepper-jk commented 5 years ago

For most tests regarding the attacks, we currently compate the sha256 hash from the generated pcap to a hard coded hash.

https://github.com/tklab-tud/ID2T/blob/master/code/Test/test_DDoSAttack.py#L6-L12 https://github.com/tklab-tud/ID2T/blob/master/code/Test/test_DDoSAttack.py#L29

We need a better way to test Attacks.

pepper-jk commented 5 years ago

Done. Using order tests to improve coverage instead for now. See: b6edbd1f201b5633fd220e275490b1139b9e7b20

There might be new tests needed to test the attacks in more detail. This should be done after refactoring the attacks even more, since they will be more modular afterwards and more generic.