adding functionality (query app run always and scan for all hosts)

tklauser / llmnrd

Link-Local Multicast Resolution (LLMNR) Daemon for Linux

GNU General Public License v2.0

45 stars 20 forks source link

adding functionality (query app run always and scan for all hosts) #26

Closed emrebayrm closed 6 years ago

emrebayrm commented 6 years ago

Hello, I add some functionality but I don't know it fits RFC document. It is very useful to me so I want to publish. I add 2 functionality :

Scan all network by typing "" to NAME** option in llmnr-query app.
llmnr-query app can always run now. With that solution, we can see any changes when happened. (-R option)

tklauser commented 6 years ago

Hi @emrebayrm and sorry for the late reply (I was on vacation). I'll take a closer look at this PR next week but in the meantime may I ask you to squash the commits, so the PR ends up with just 1 commit instead of a lot of typo/fix commits? Also, please describe your changes in the commit message (i.e. use what you wrote in the PR description).

Thanks a lot!

tklauser commented 6 years ago

Hi again. After giving this PR a bit of thought, I don't think it is a feature we should add to llmnrd. The main reason being that it is not specified in the RFC and thus not implemented in other LLMNR implementations. This would mean that llmnr-query would only discover devices running llmnrd including this PR which might not be the complete picture.

So I think, I'll not merge this PR in its current form, sorry.