Better way to find dimnames for matrix

tklebel / crosstabr

Cross tabulation with HTML and Markdown output

Other

1 stars 0 forks source link

Closed tklebel closed 8 years ago

tklebel commented 8 years ago

Currently, dimnames are retrieved from the proportional data.frame by levels.

Check if this approach is always valid. It should always find the correct labels for the resulting table
Think about, what to do with unused levels (levels which were changed to NA, where the level-vector stays the same). Should they simply be dropped by default? Should there be an option to keep them? (if yes, why?)

tklebel commented 8 years ago

Unused levels should be retained, otherwise unobserved combinations would simply be dropped.

The approach to retrieve dimnames from levels seems to be valid.