tkluck / GaloisFields.jl

Finite fields for Julia

Other

47 stars 6 forks source link

Fix divisions of form 0/k for Zech's logarithms #1

Closed b-reinke closed 5 years ago

b-reinke commented 5 years ago

This pull request adds the case 0/k to division using Zech's logarithms. It fixes the following bug:

julia> using GaloisFields
julia> G = @GaloisFields! 9 b
julia> G(0)/G(1)
ERROR: KeyError: key 0 not found

codecov[bot] commented 5 years ago

Codecov Report

Merging #1 into master will increase coverage by 0.03%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   86.02%   86.05%   +0.03%     
==========================================
  Files           9        9              
  Lines         458      459       +1     
==========================================
+ Hits          394      395       +1     
  Misses         64       64

Impacted Files	Coverage Δ
src/ZechLog.jl	`97.29% <100%> (+0.07%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1eb0616...bc99c6f. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #1 into master will increase coverage by 0.03%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   86.02%   86.05%   +0.03%     
==========================================
  Files           9        9              
  Lines         458      459       +1     
==========================================
+ Hits          394      395       +1     
  Misses         64       64

Impacted Files	Coverage Δ
src/ZechLog.jl	`97.29% <100%> (+0.07%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1eb0616...bc99c6f. Read the comment docs.

tkluck commented 5 years ago

Thank you! We should add a test case too.

tkluck commented 5 years ago

PS I'll do a point release for this one hopefully later today.

b-reinke commented 5 years ago

Would you mind also adjusting the definition of 0^0 and 0^pos? I have a local fix as well, and I was about to add it to the pull request.

tkluck commented 5 years ago

Pushed a few extra fixes and added them to the release-0.3 branch.

@JuliaRegistrator register(branch="release-0.3")