search

tkn-tub / ns3-gym

ns3-gym - The Playground for Reinforcement Learning in Networking Research
GNU General Public License v2.0
521 stars 197 forks source link

Add boost to installation instructions #7

Closed DvdMgr closed 5 years ago

DvdMgr commented 5 years ago

boost/algorithm/string.hpp is included in opengym_interface.cc, but the installation instructions do not mention boost. This commit adds a line to the readme that installs boost, so that ns-3 compilation goes smoothly.

pgawlowicz commented 5 years ago

Hi, Thanks for pointing this out. Actually, boost is not required and there was only old include in opengym_interface.cc. I have cleaned includes in opengym module. See commit

DvdMgr commented 5 years ago

That’s even better then, thanks for the prompt reply!

Il giorno lun 26 nov 2018 alle 20:35 Piotr notifications@github.com ha scritto:

Hi, Thanks for pointing this out. Actually, boost is not required and there was only old include in opengym_interface.cc. I have cleaned includes in opengym module. See commit https://github.com/tkn-tub/ns3-gym/commit/d07797076ede0b2eec040ab6a46e668888f751e0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tkn-tub/ns3-gym/pull/7#issuecomment-441768655, or mute the thread https://github.com/notifications/unsubscribe-auth/ACckCdkr-b9weOYqrZi9nQhiAMD31bwIks5uzEJ4gaJpZM4YzcDV .