fixing rsync command - Githubissues

tknerr / vagrant-managed-servers

Enables Vagrant to ssh into and provision managed servers

MIT License

185 stars 30 forks source link

fixing rsync command #15

Closed elyast closed 10 years ago

elyast commented 10 years ago

Options for ssh_private_key has changed slightly in vagrant 1.4, therefore I think it should be adjusted (like in vagrant-aws)

Second thing is vagrant 1.4.3 added proxy_command to ssh config and therefore its needed in rsync, otherwise it will fail when the managed server is behind hop server

brandonmartin commented 10 years ago

+1 4 merge.

just confirming this plugin is broken in vagrant 1.4 and this patch fixes it and the code looks fairly sound.

brandonmartin commented 10 years ago

here is the relevant PR from vagrant-aws for comparison: https://github.com/mitchellh/vagrant-aws/pull/172/files

tknerr commented 10 years ago

Thanks @elyast and @brandonmartin !

Have not tested it myself with Vagrant 1.4, but the diff it looks good :+1:

tknerr commented 10 years ago