search

tknerr / vagrant-managed-servers

Enables Vagrant to ssh into and provision managed servers
MIT License
185 stars 30 forks source link

HandleBoxUrl middleware is deprecated. Use HandleBox instead. #19

Closed nicolasbrechet closed 10 years ago

nicolasbrechet commented 10 years ago

Hello,

I'm starting to use this plugin and here's an error message I got:

HandleBoxUrl middleware is deprecated. Use HandleBox instead.
==> default: This is a bug with the provider. Please contact the creator
==> default: of the provider you use to fix this

I'm using Vagrant 1.6.2, ruby 2.1.1p76, and vagrant-managed-servers (0.2.0).

Is it something you're aware of ?

Thanks!

Nicolas

tknerr commented 10 years ago

@nicolasbrechet sorry, not aware of it until you mentioned it, I'm still on Vagrant 1.3.5 (which is the last version to support bindler)...

Is it just a deprecation warning or does it break the plugin's functionality?

I'm probably not going to have the time for fixing this in the next weeks, maybe yes, maybe no. Pull requests are always welcome though.

P.S.: to keep it backwards-compatible we could add a version check similar to this: 

if Vagrant::VERSION < '1.6.0'
  # use HandleBoxUrl...
else
  # use HandleBox...
end
nicolasbrechet commented 10 years ago

It's a deprecation warning but it works fine. I'll use your suggestion and send a PR.

Thanks!

tknerr commented 10 years ago

Thanks @nicolasbrechet!

tknerr commented 10 years ago

This is included in the v0.3.0 release