search

tknerr / vagrant-managed-servers

Enables Vagrant to ssh into and provision managed servers
MIT License
185 stars 30 forks source link

Wrong exit code when server is not reachable #72

Open JMLX42 opened 6 years ago

JMLX42 commented 6 years ago

Expected behavior

$ vagrant provision dev
==> dev: The managed server is not reachable. Check if the `config.managed.server` is correct.
$ echo $?
1

Actual behavior

$ vagrant provision dev
==> dev: The managed server is not reachable. Check if the `config.managed.server` is correct.
$ echo $?
0
pvalena commented 4 years ago

This is not good :(

tknerr commented 4 years ago

Hey @promethe42 , @pvalena ,

sorry for the delay in response. I'm currently not finding time to properly support this as needed, but I'm happy to accept pull requests for this.

Only issue is that before making any functional changes:

  1. the plugin should be lifted to be compatible with latest vagrant version
  2. the.travis.yml is currently failing and needs to be fixed

I will try to find some time during the next days. If you want to support, I'm happy about PRs as well.

Cheers, Torben

pvalena commented 4 years ago

the plugin should be lifted to be compatible with latest vagrant version

How's that? We're experimenting with it, and it works fine, currently. Do you have some specifics?

I'll try to check travis-ci failures later on, but I'm no expert.