search

tknopp / SparsityOperators.jl

Other
0 stars 3 forks source link

CompatHelper: bump compat for LinearOperators to 2, (keep existing compat) #9

Open github-actions[bot] opened 2 years ago

github-actions[bot] commented 2 years ago

This pull request changes the compat entry for the LinearOperators package from 1.0 to 1.0, 2. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

JakobAsslaender commented 2 years ago

Hi! Any plans on bumping LinearOperators compat to v2? It seems that one would have to replace the * operations with 5-argument mul!operations, which would, IMHO, prevent some memory allocations here and there, but also this compat seems to be causing issues with using this package along with others that have switched to v2 and v1.3 uses outdated packages itself, causing more problems ...

I tried to modify things myself, but I don't think I understand the code enough myself.

Thanks for considering looking into this!!! -ja

tknopp commented 2 years ago

Yes we should definitely do this, but I have not looked into what they changed.

tknopp commented 2 years ago

11 is work in progress.