tkqubo / codeclimate-tslint

Code Climate TSLint-Engine
40 stars 20 forks source link

Migrate to CircleCI 2.0 #50

Closed wingrunr21 closed 5 years ago

wingrunr21 commented 6 years ago

CircleCI 1.0 was end of life at the end of August. This PR migrates to Circle 2.0 + upgrades the test/coverage stuff to use tools like ts-node and nyc.

wingrunr21 commented 6 years ago

Note that neither one of the CircleCI builds will pass right off the bat:

The legacy one won't pass as Circle 1.0 is no longer working. The new one won't pass because cc-test-reporter needs the CC_TEST_REPORTER_ID variable set so it can upload coverage to CodeClimate

sdrioux commented 5 years ago

@tkqubo can we get this merged?

tkqubo commented 5 years ago

I merged this PR. Sorry for the delay! @wingrunr21 @sdrioux

wingrunr21 commented 5 years ago

@tkqubo looks like the Circle build still needs CC_TEST_REPORTER_ID set in order to pass: https://circleci.com/gh/tkqubo/codeclimate-tslint/128

CodeClimate docs on it: https://github.com/codeclimate/test-reporter