search

tkrajcar / carbonmu

CarbonMU was experiments towards a general-purpose, extendable MUD/MUSH server written in Ruby.
MIT License
13 stars 5 forks source link

Tests suddenly became super slow #24

Closed tkrajcar closed 9 years ago

tkrajcar commented 9 years ago

Something in 07a9eae made each rspec suite slow. Like really slow. Need to find out what it is and fix.

tkrajcar commented 9 years ago

This is fixed now! The problem was that we introduced player passwords, and between every single spec, the database cleaner was running, and then the 'starter objects' were created (which includes a player, with a password). Since bcrypt is intentionally computationally expensive, hashing the password for the new player took some amount of computation time. I lowered the bcrypt 'cost' in https://github.com/tkrajcar/carbonmu/commit/33281cf4f1bd3f1ae9d6418716ed49e36b40a551 and then decided to go a step further and only have the starter objects created when absolutely necessary in https://github.com/tkrajcar/carbonmu/commit/f388c7a278282dd8f54dc9cbec04907008d8384e. Test run on 2.2.2 went from 32.5 seconds to 0.67 seconds.

cc @1337807 @zoevkay