search

tkrajina / gpxgo

GPX library for golang
Apache License 2.0
93 stars 23 forks source link

Add subseconds to timelayout #4

Closed mlouielu closed 6 years ago

tkrajina commented 6 years ago

@mlouielu thanks for your pull request. But note that changing the first element in this list affects parsing and formatting. And most gpx files come without milliseconds (<time>2002-02-10T21:01:29.250Z</time>).

Another thing, test fail with your change (make test to try it yourself).

I'd propose to change the list, leave the first timestamp as it is and add "2006-01-02T15:04:05.000Z" after it.

PS. I should probably setup a CI build for gpxgo.

mlouielu commented 6 years ago

I think it should need to accept parameter from the function or somewhere else, IIRC timelayout currently only use the first one, right?