search

tkrajina / gpxpy

gpx-py is a python GPX parser. GPX (GPS eXchange Format) is an XML based file format for GPS tracks.
Apache License 2.0
989 stars 223 forks source link

Use some kind of automated testing? #153

Closed 1kastner closed 5 years ago

1kastner commented 5 years ago

Would something like AppVeyor (see https://github.com/ogrisel/python-appveyor-demo) or Travis-CI (see https://github.com/pypa/python-manylinux-demo) be worthwhile looking at for this project? I think the idea of automatically testing code as soon as it is merged is great. If you like, I might want to give it a try and you'll see a pull request somewhen soon.

hugovk commented 5 years ago

Travis CI already runs unit tests for PRs and merges:

https://github.com/tkrajina/gpxpy/blob/master/.travis.yml

https://travis-ci.org/tkrajina/gpxpy

1kastner commented 5 years ago

Maybe it could also be done for the code of the readme file? Because I spotted yet another print-without-brackets. There are approaches like https://github.com/mrocklin/pymarkdown or https://github.com/jpsenior/sphinx-execute-code which could avoid having mixed Python 2 / 3 code on the very first page of the project :P

hugovk commented 5 years ago

Maybe it could also be done for the code of the readme file? Because I spotted yet another print-without-brackets. There are approaches like mrocklin/pymarkdown or jpsenior/sphinx-execute-code which could avoid having mixed Python 2 / 3 code on the very first page of the project :P

mrocklin/pymarkdown says:

You should not use this project. You should use knitpy.

(See https://github.com/tkrajina/gpxpy/pull/164 to fix the print.)

tkrajina commented 5 years ago

If this is only about the code in the README files, there aren't that many code there. And most errors are those python2/python3 print statements which, once solved, are solved forewer.