search

tkrajina / gpxpy

gpx-py is a python GPX parser. GPX (GPS eXchange Format) is an XML based file format for GPS tracks.
Apache License 2.0
987 stars 223 forks source link

Typo: type_of_gpx_fix should be type_of_gps_fix ? #205

Open gregoryng opened 4 years ago

gregoryng commented 4 years ago

Minor typo shows up in a few places in gpx.py. There is a field called "type_of_gpx_fix", but I think it should be called "type_of_gps_fix." I assume it is referring to "type of gps fix", which the topografix manual has also made this error in one spot, but generally refers to this as "GPS fix".

I guess it is consistent in the code to internally call it "type_of_gpx_fix" rather than "type_of_gps_fix", but technically it doesn't quite make sense.

I see 8 occurrences in gpx.py but this is the first: https://github.com/tkrajina/gpxpy/blob/4b90ead7163008953f2fd0ebb998e86320bc9f84/gpxpy/gpx.py#L66

It also shows up in test.py.

Don't know if the right response is to allow either field or to deprecate type_of_gpx_fix.

tkrajina commented 3 years ago

Yes, you're right. Thanks for pointing this out.

I'm also not sure how to fix it, but I'll think of something.